linux-kernel - Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d3d8684-fe20-0bc8-7465-53c5f7b55447@xs4all.nl>
Date:	Wed, 13 Jul 2016 09:05:27 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Andrey Utkin <andrey_utkin@...tmail.com>,
	Andrey Utkin <andrey.utkin@...p.bluecherry.net>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bluecherry Maintainers <maintainers@...echerrydvr.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Kalle Valo <kvalo@...eaurora.org>,
	Joe Perches <joe@...ches.com>, Jiri Slaby <jslaby@...e.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Kozlov Sergey <serjk@...up.ru>,
	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Krzysztof Hałasa <khalasa@...p.pl>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-pci@...r.kernel.org,
	kernel-mentors@...enic.com
Subject: Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits,
 going to resubmit soon

On 07/13/2016 04:05 AM, Andrey Utkin wrote:
> Found and fixed few very minor coding style nits, will resubmit in few days,
> now still waiting for comments to v4.

Can you resubmit now? I plan to review it on Friday or Monday, and I'd rather
review the latest version.

Regards,

	Hans

> 
> https://github.com/bluecherrydvr/linux/commits/tw5864
> 
> commit 31f7c98a144cb3fb8a94662f002d9b6142d1f390
> Author: Andrey Utkin <andrey.utkin@...p.bluecherry.net>
> Date:   Wed Jul 13 05:00:28 2016 +0300
> 
>     Fix checkpatch --strict issue
>     
>      CHECK: Alignment should match open parenthesis
>      #3599: FILE: drivers/media/pci/tw5864/tw5864-video.c:539:
>      +static int tw5864_fmt_vid_cap(struct file *file, void *priv,
>      +                               struct v4l2_format *f)
> 
> commit 11a09a1048af597ecf374507b08c809eed91b86d
> Author: Andrey Utkin <andrey.utkin@...p.bluecherry.net>
> Date:   Wed Jul 13 04:59:34 2016 +0300
> 
>     Fix checkpatch --strict issue
>     
>      CHECK: Please don't use multiple blank lines
>      #3244: FILE: drivers/media/pci/tw5864/tw5864-video.c:184:
> 
> commit 861b2ba8593db7abe89291a4ba85976519783f4a
> Author: Andrey Utkin <andrey.utkin@...p.bluecherry.net>
> Date:   Wed Jul 13 04:58:37 2016 +0300
> 
>     Fix checkpatch --strict issue
>     
>      CHECK: No space is necessary after a cast
>      #3053: FILE: drivers/media/pci/tw5864/tw5864-util.c:36:
>      +       return (u8) tw_readl(TW5864_IND_DATA);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>