linux-kernel - Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <578618CA.8090808@samsung.com>
Date:	Wed, 13 Jul 2016 12:32:42 +0200
From:	Sylwester Nawrocki <s.nawrocki@...sung.com>
To:	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-kernel@...r.kernel.org, Tomasz Figa <tomasz.figa@...il.com>,
	linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly
 non-modular

On 07/04/2016 11:12 PM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> arch/arm/mach-s5pv210/Kconfig:config ARCH_S5PV210
> arch/arm/mach-s5pv210/Kconfig:  bool "Samsung S5PV210/S5PC110" if ARCH_MULTI_V7
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
> 
> Since this code is already not using module_init, case, the init
> ordering remains unchanged with this commit.
> 
> We also delete the MODULE_LICENSE tags etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>
> Cc: Tomasz Figa <tomasz.figa@...il.com>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...eaurora.org>
> Cc: linux-samsung-soc@...r.kernel.org
> Cc: linux-clk@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

In case this is going to be applied directly to current clk-next:

Acked-by: Sylwester Nawrocki <s.nawrocki@...sung.com>