linux-kernel - Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <32897348-2AC5-4AB7-BF58-B1E36FC19CF2@holtmann.org>
Date:	Wed, 13 Jul 2016 11:56:02 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"Gustavo F. Padovan" <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Pavan Savoy <pavan_savoy@...com>,
	Arnd Bergmann <arnd@...db.de>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>,
	linux-media@...r.kernel.org,
	linux-wireless <linux-wireless@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status

Hi Mauro,

>> On mips and parisc:
>> 
>>    drivers/bluetooth/btwilink.c: In function 'ti_st_open':
>>    drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit constant conversion [-Woverflow]
>>       hst->reg_status = -EINPROGRESS;
>> 
>>    drivers/nfc/nfcwilink.c: In function 'nfcwilink_open':
>>    drivers/nfc/nfcwilink.c:396:31: warning: overflow in implicit constant conversion [-Woverflow]
>>      drv->st_register_cb_status = -EINPROGRESS;
>> 
>> There are actually two issues:
>>  1. Whether "char" is signed or unsigned depends on the architecture.
>>     As the completion callback data is used to pass a (negative) error
>>     code, it should always be signed.
>>  2. EINPROGRESS is 150 on mips, 245 on parisc.
>>     Hence -EINPROGRESS doesn't fit in a signed 8-bit number.
>> 
>> Change the callback status from "char" to "int" to fix these.
>> 
>> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> 
> Patch looks sane to me, but who will apply it?
> 
> Anyway:
> 
> Acked-by: Mauro Carvalho Chehab <mchehab@...pensource.com>

I can take it through bluetooth-next if there is no objection.

Samuel, are you fine with that?

Regards

Marcel