lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jul 2016 14:36:57 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Silvan Jegen <s.jegen@...il.com> Cc: Phillip Lougher <phillip@...ashfs.org.uk>, lkml <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [patch] Squashfs: silence some uninitialized variable warnings On Wed, Jul 13, 2016 at 01:29:32PM +0200, Silvan Jegen wrote: > Hi Dan > > On Wed, Jul 13, 2016 at 12:02 PM, Dan Carpenter > <dan.carpenter@...cle.com> wrote: > > We print these values in the TRACE() code before we check that > > fill_meta_index() was successful. It makes my static checker complain. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> > > > > diff --git a/fs/squashfs/file.c b/fs/squashfs/file.c > > index 13d8094..46679e2 100644 > > --- a/fs/squashfs/file.c > > +++ b/fs/squashfs/file.c > > @@ -334,9 +334,9 @@ failed: > > */ > > static int read_blocklist(struct inode *inode, int index, u64 *block) > > { > > - u64 start; > > + u64 start = -1; > > Do you assign the negative value to the unsigned variable here on purpose? > Yeah. It's just a garbage value but hopefully it would stand out in the printk. regards, dan carpenter
Powered by blists - more mailing lists