linux-kernel - Re: [PATCH -next] drm: atmel-hlcdc: fix non static symbol warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160713145841.32b12eff@bbrezillon>
Date:	Wed, 13 Jul 2016 14:58:41 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	weiyj_lk@....com
Cc:	David Airlie <airlied@...ux.ie>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH -next] drm: atmel-hlcdc: fix non static symbol warning

On Wed, 13 Jul 2016 12:43:03 +0000
weiyj_lk@....com wrote:

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fixes the following sparse warning:
> 
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning:
>  symbol 'atmel_hlcdc_crtc_reset' was not declared. Should it be static?

Sorry but Thierry already proposed the same fix a few days ago.

> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> index a978381..9b17a66 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> @@ -387,7 +387,7 @@ void atmel_hlcdc_crtc_irq(struct drm_crtc *c)
>  	atmel_hlcdc_crtc_finish_page_flip(drm_crtc_to_atmel_hlcdc_crtc(c));
>  }
>  
> -void atmel_hlcdc_crtc_reset(struct drm_crtc *crtc)
> +static void atmel_hlcdc_crtc_reset(struct drm_crtc *crtc)
>  {
>  	struct atmel_hlcdc_crtc_state *state;
>  
> 
> 
> 
>