[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160713134941.GA10985@rob-hp-laptop>
Date: Wed, 13 Jul 2016 08:49:41 -0500
From: Rob Herring <robh@...nel.org>
To: Chris Zhong <zyw@...k-chips.com>
Cc: dianders@...omium.org, tfiga@...omium.org, heiko@...ech.de,
yzq@...k-chips.com, linux-rockchip@...ts.infradead.org,
Mark Yao <mark.yao@...k-chips.com>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: add rk3399 support for dw-mipi-rockchip
On Fri, Jul 08, 2016 at 05:04:55PM +0800, Chris Zhong wrote:
> The dw-mipi-dsi of rk3399 is almost the same as rk3288, the rk3399 has
> additional phy config clock.
>
> Signed-off-by: Chris Zhong <zyw@...k-chips.com>
> ---
>
> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> index 1753f0c..4d59df3 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> @@ -5,6 +5,7 @@ Required properties:
> - #address-cells: Should be <1>.
> - #size-cells: Should be <0>.
> - compatible: "rockchip,rk3288-mipi-dsi", "snps,dw-mipi-dsi".
> + "rockchip,rk3399-mipi-dsi", "snps,dw-mipi-dsi".
> - reg: Represent the physical address range of the controller.
> - interrupts: Represent the controller's interrupt to the CPU(s).
> - clocks, clock-names: Phandles to the controller's pll reference
> @@ -13,6 +14,10 @@ Required properties:
> - ports: contain a port node with endpoint definitions as defined in [2].
> For vopb,set the reg = <0> and set the reg = <1> for vopl.
>
> +Optional properties:
> +- clocks, clock-names: phandle to the dw-mipi phy clock, name should be
> + "phy_cfg".
> +
This is not really optional. It is required for rk3399. Document with
the rest of the clocks and note this one is rk3399 only.
Rob
Powered by blists - more mailing lists