linux-kernel - Re: [PATCH v15 09/12] perf record: Read from overwritable ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160713140630.GA31742@krava>
Date:	Wed, 13 Jul 2016 16:06:30 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	acme@...nel.org, lizefan@...wei.com, linux-kernel@...r.kernel.org,
	pi3orama@....com, He Kuang <hekuang@...wei.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Nilay Vaish <nilayvaish@...il.com>
Subject: Re: [PATCH v15 09/12] perf record: Read from overwritable ring buffer

On Tue, Jul 12, 2016 at 10:00:09AM +0000, Wang Nan wrote:

SNIP

> + * (1): Pause ring buffers for reading
> + * (2): Read from ring buffers
> + * (3): Resume ring buffers for recording
> + */
> +enum overwrite_evt_state {
> +	OVERWRITE_EVT_RUNNING,
> +	OVERWRITE_EVT_DATA_PENDING,
> +	OVERWRITE_EVT_EMPTY,
> +};
>  
>  struct record {
>  	struct perf_tool	tool;
> @@ -61,6 +85,7 @@ struct record {
>  	bool			buildid_all;
>  	bool			timestamp_filename;
>  	bool			switch_output;
> +	enum overwrite_evt_state overwrite_evt_state;
>  	unsigned long long	samples;

I wonder this would be better to have in 'struct evlist',
also 'enum owr_mmap_state'  might be better name then

thanks,
jirka