linux-kernel - Re: [PATCH v15 03/12] perf tools: Update perf evlist mmap related APIs and helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Jul 2016 16:06:37 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	acme@...nel.org, lizefan@...wei.com, linux-kernel@...r.kernel.org,
	pi3orama@....com, Arnaldo Carvalho de Melo <acme@...hat.com>,
	He Kuang <hekuang@...wei.com>, Jiri Olsa <jolsa@...nel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Nilay Vaish <nilayvaish@...il.com>
Subject: Re: [PATCH v15 03/12] perf tools: Update perf evlist mmap related
 APIs and helpers

On Tue, Jul 12, 2016 at 10:00:03AM +0000, Wang Nan wrote:

SNIP

> -union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int idx)
> +union perf_event *perf_mmap__read_forward(struct perf_mmap *md, bool overwrite)
>  {
> -	struct perf_mmap *md = &evlist->mmap[idx];
>  	u64 head;
>  	u64 old = md->prev;
>  
> @@ -795,13 +795,12 @@ union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int
>  
>  	head = perf_mmap__read_head(md);
>  
> -	return perf_mmap__read(md, evlist->overwrite, old, head, &md->prev);
> +	return perf_mmap__read(md, overwrite, old, head, &md->prev);
>  }
>  
>  union perf_event *
> -perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
> +perf_mmap__read_backward(struct perf_mmap *md, bool overwrite __maybe_unused)
>  {
> -	struct perf_mmap *md = &evlist->mmap[idx];
>  	u64 head, end;
>  	u64 start = md->prev;
>  
> @@ -836,6 +835,20 @@ perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
>  	return perf_mmap__read(md, false, start, end, &md->prev);

should you pas evlist->overwrite in here?

thanks,
jirka