linux-kernel - Re: [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160714001300.2e70fe9b3cfb98d5e92e8620@kernel.org>
Date:	Thu, 14 Jul 2016 00:13:00 +0900
From:	Masami Hiramatsu <mhiramat@...nel.org>
To:	Christoph Hellwig <hch@....de>
Cc:	ananth@...ux.vnet.ibm.com, anil.s.keshavamurthy@...el.com,
	davem@...emloft.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kprobes: include <asm/sections.h> instead of
 <asm-generic/sections.h>

On Tue, 12 Jul 2016 09:57:36 +0900
Christoph Hellwig <hch@....de> wrote:

> asm-generic headers are generic implementations for architecture specific
> code and should not be included by common code.  Thus use the asm/ version
> of sections.h to get at the linker sections.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Looks good to me. Thanks Christoph!

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

> ---
>  kernel/kprobes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index d10ab6b..d630954 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -49,7 +49,7 @@
>  #include <linux/cpu.h>
>  #include <linux/jump_label.h>
>  
> -#include <asm-generic/sections.h>
> +#include <asm/sections.h>
>  #include <asm/cacheflush.h>
>  #include <asm/errno.h>
>  #include <asm/uaccess.h>
> -- 
> 2.1.4
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>