| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jul 2016 01:04:22 +0800
From: kbuild test robot <lkp@...el.com>
To: Ed Swierk <eswierk@...portsystems.com>
Cc: kbuild-all@...org, tpmdd-devel@...ts.sourceforge.net,
linux-kernel@...r.kernel.org,
linux-security-module@...r.kernel.org,
jarkko.sakkinen@...ux.intel.com, jgunthorpe@...idianresearch.com,
stefanb@...ibm.com, eswierk@...portsystems.com
Subject: Re: [PATCH v9 4/5] tpm: Allow TPM chip drivers to override reported
command durations
Hi,
[auto build test WARNING on next-20160712]
[cannot apply to char-misc/char-misc-testing v4.7-rc7 v4.7-rc6 v4.7-rc5 v4.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ed-Swierk/tpm-Command-duration-logging-and-chip-specific-override/20160714-002547
config: i386-randconfig-s1-201628 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_update_timeouts':
>> drivers/char/tpm/tpm_tis_core.c:414:10: warning: 'return' with a value, in function returning void
return rc;
^~
drivers/char/tpm/tpm_tis_core.c:406:13: note: declared here
static void tpm_tis_update_timeouts(struct tpm_chip *chip)
^~~~~~~~~~~~~~~~~~~~~~~
vim +/return +414 drivers/char/tpm/tpm_tis_core.c
41a5e1cf Christophe Ricard 2016-05-19 398 if (!priv->irq_tested)
41a5e1cf Christophe Ricard 2016-05-19 399 msleep(1);
41a5e1cf Christophe Ricard 2016-05-19 400 if (!priv->irq_tested)
41a5e1cf Christophe Ricard 2016-05-19 401 disable_interrupts(chip);
41a5e1cf Christophe Ricard 2016-05-19 402 priv->irq_tested = true;
41a5e1cf Christophe Ricard 2016-05-19 403 return rc;
41a5e1cf Christophe Ricard 2016-05-19 404 }
41a5e1cf Christophe Ricard 2016-05-19 405
a7da7fe7 Ed Swierk 2016-07-13 406 static void tpm_tis_update_timeouts(struct tpm_chip *chip)
41a5e1cf Christophe Ricard 2016-05-19 407 {
41a5e1cf Christophe Ricard 2016-05-19 408 struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
a7da7fe7 Ed Swierk 2016-07-13 409 int rc;
41a5e1cf Christophe Ricard 2016-05-19 410 u32 did_vid;
41a5e1cf Christophe Ricard 2016-05-19 411
41a5e1cf Christophe Ricard 2016-05-19 412 rc = tpm_tis_read32(priv, TPM_DID_VID(0), &did_vid);
41a5e1cf Christophe Ricard 2016-05-19 413 if (rc < 0)
41a5e1cf Christophe Ricard 2016-05-19 @414 return rc;
41a5e1cf Christophe Ricard 2016-05-19 415
a7da7fe7 Ed Swierk 2016-07-13 416 switch (did_vid) {
a7da7fe7 Ed Swierk 2016-07-13 417 case 0x32041114: /* Atmel 3204 */
a7da7fe7 Ed Swierk 2016-07-13 418 chip->timeout_a = msecs_to_jiffies(TIS_SHORT_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 419 chip->timeout_b = msecs_to_jiffies(TIS_LONG_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 420 chip->timeout_c = msecs_to_jiffies(TIS_SHORT_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 421 chip->timeout_d = msecs_to_jiffies(TIS_SHORT_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 422 chip->timeout_adjusted = true;
:::::: The code at line 414 was first introduced by commit
:::::: 41a5e1cf1fe151ed48b4b3106c748d03a85133ce tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy
:::::: TO: Christophe Ricard <christophe.ricard@...il.com>
:::::: CC: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/octet-stream" (22818 bytes)
Powered by blists - more mailing lists