linux-kernel - Re: Severe performance regression w/ 4.4+ on Android due to cgroup locking changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160713210315.GO7094@linux.vnet.ibm.com>
Date:	Wed, 13 Jul 2016 14:03:15 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Tejun Heo <tj@...nel.org>, John Stultz <john.stultz@...aro.org>,
	Ingo Molnar <mingo@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Dmitry Shmidt <dimitrysh@...gle.com>,
	Rom Lemarchand <romlem@...gle.com>,
	Colin Cross <ccross@...gle.com>, Todd Kjos <tkjos@...gle.com>,
	Oleg Nesterov <oleg@...hat.com>
Subject: Re: Severe performance regression w/ 4.4+ on Android due to cgroup
 locking changes

On Wed, Jul 13, 2016 at 10:51:02PM +0200, Peter Zijlstra wrote:
> On Wed, Jul 13, 2016 at 04:39:44PM -0400, Tejun Heo wrote:
> 
> > > There is a synchronize_sched() in there, so sorta. That thing is heavily
> > > geared towards readers, as is the only 'sane' choice for global locks.
> > 
> > It used to use the expedited variant until 001dac627ff3
> > ("locking/percpu-rwsem: Make use of the rcu_sync infrastructure"), so
> > it might have been okay before then.
> 
> Right, but expedited stuff sprays IPIs around the entire system. That's
> stuff other people complain about.

Do anyone other than the non-NO_HZ_FULL low-latency guys and the -rt
guys care?

> > The options that I can see are
> > 
> > 1. Somehow make percpu_rwsem's write behavior more responsive in a way
> >    which is acceptable all use cases.  This would be great but
> >    probably impossible.
> > 
> > 2. Add a fast-writer option to percpu_rwsem so that users which care
> >    about write latency can opt in for higher processing overhead for
> >    lower latency.
> 
> So, IIRC, the trade-off is a full memory barrier in read_lock and
> read_unlock() vs sync_sched() in write.
> 
> Full memory barriers are expensive and while the combined cost might
> well exceed the cost of the sync_sched() it doesn't suffer the latency
> issues.
> 
> Not sure if we can frob the two in a single codebase, but I can have a
> poke if Oleg or Paul doesn't beat me to it.

Take the patch that I just sent out and make the choice of normal
vs. expedited depend on CONFIG_PREEMPT_RT or whatever the -rt guys are
calling it these days.  Is there a low-latency Kconfig option other
than CONFIG_NO_HZ_FULL?

The memory-barrier approach can definitely be made to work, but is
going to be more complex due to the need to wait for readers.

							Thanx, Paul