[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ee643539b279eb6e5d1a3b8a33f46cb2@agner.ch>
Date: Wed, 13 Jul 2016 22:50:59 -0700
From: Stefan Agner <stefan@...er.ch>
To: Peter Chen <peter.chen@....com>
Cc: airlied@...ux.ie, alison.wang@...escale.com,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] gpn: drm: fsl_tcon: add missing of_node_put after
calling of_parse_phandle
On 2016-07-04 00:40, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using, but current code only
> calls it at error path, fix it by adding it at correct code path.
>
> Signed-off-by: Peter Chen <peter.chen@....com>
> ---
> drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
> b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
> index bbe34f1..bca09ea 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
> @@ -92,6 +92,7 @@ struct fsl_tcon *fsl_tcon_init(struct device *dev)
> goto err_node_put;
> }
>
> + of_node_put(np);
> clk_prepare_enable(tcon->ipg_clk);
>
> dev_info(dev, "Using TCON in bypass mode\n");
Thanks, applied!
Changed subject prefix using the usual drm/fsl-dcu:...
--
Stefan
Powered by blists - more mailing lists