linux-kernel - Re: [PATCH] iommu/iova: validate iova_domain input to put_iova

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160714083420.GR12639@8bytes.org>
Date:	Thu, 14 Jul 2016 10:34:20 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Nate Watterson <nwatters@...eaurora.org>
Cc:	robin.murphy@....com, iommu@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/iova: validate iova_domain input to put_iova_domain

On Wed, Jul 13, 2016 at 02:49:32PM -0400, Nate Watterson wrote:
> Passing a NULL or uninitialized iova_domain into put_iova_domain
> will currently crash the kernel when the unconfigured iova_domain
> data members are accessed. To prevent this from occurring, this patch
> adds a check to make sure that the domain is non-NULL and that the
> domain granule is non-zero. The granule can be used to check if the
> domain was properly initialized because calling init_iova_domain
> with a granule of zero would have already triggered a BUG statement
> crashing the kernel.

Have you seen real crashes happening because of this?


	Joerg