linux-kernel - Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160714085138.GD2228@nanopsycho.orion>
Date:	Thu, 14 Jul 2016 10:51:38 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...hat.com>,
	"David S . Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] devlink: fix build error for
 CONFIG_MODULES=n

Thu, Jul 14, 2016 at 10:12:43AM CEST, arnd@...db.de wrote:
>On Thursday, July 14, 2016 8:21:11 AM CEST Jiri Pirko wrote:
>> >diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h
>> >index 333c32ac9bfa..26f92d3c7e9c 100644
>> >--- a/include/trace/events/devlink.h
>> >+++ b/include/trace/events/devlink.h
>> >@@ -22,7 +22,11 @@ TRACE_EVENT(devlink_hwmsg,
>> >       TP_STRUCT__entry(
>> >               __string(bus_name, devlink->dev->bus->name)
>> >               __string(dev_name, dev_name(devlink->dev))
>> >+#ifdef CONFIG_MODULES
>> >               __string(owner_name, devlink->dev->driver->owner->name)
>> 
>> I think would be better to use driver->name. I looks like it is always
>> present. I will do some tests and send a patch.
>> 
>
>Yes, good idea.


I will take your second path, rebase and send along. Thanks.

>
>	Arnd
>