linux-kernel - [PATCH] Enclose multiple statements macros in a do while loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1468486911-10916-1-git-send-email-sunbing@redflag-linux.com>
Date:	Thu, 14 Jul 2016 17:01:51 +0800
From:	Sunbing <sunbing@...flag-linux.com>
To:	gregkh@...uxfoundation.org, wsa+renesas@...g-engineering.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Cc:	Sunbing <sunbing@...flag-linux.com>,
	Sunbing <sunbing.linux@...il.com>
Subject: [PATCH] Enclose multiple statements macros in a do while loop

The formatting of macros definetion in ks7010/michael_mic.c is not
consistent with the general kernel coding style.

Fix it by the result of scripts/checkpatch.pl.

No functional changes.

Signed-off-by: Sunbing <sunbing.linux@...il.com>
---
 drivers/staging/ks7010/michael_mic.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c
index e14c109..ad4f779 100644
--- a/drivers/staging/ks7010/michael_mic.c
+++ b/drivers/staging/ks7010/michael_mic.c
@@ -20,15 +20,21 @@
 #define getUInt32( A, B ) 	(uint32_t)(A[B+0] << 0) + (A[B+1] << 8) + (A[B+2] << 16) + (A[B+3] << 24)
 
 // Convert from UInt32 to Byte[] in a portable way
-#define putUInt32( A, B, C ) 	A[B+0] = (uint8_t) (C & 0xff);		\
-				A[B+1] = (uint8_t) ((C>>8) & 0xff);	\
-				A[B+2] = (uint8_t) ((C>>16) & 0xff);	\
-				A[B+3] = (uint8_t) ((C>>24) & 0xff)
+#define putUInt32(A, B, C)					\
+do {								\
+	A[B+0] = (uint8_t) (C & 0xff);				\
+	A[B+1] = (uint8_t) ((C>>8) & 0xff);			\
+	A[B+2] = (uint8_t) ((C>>16) & 0xff);			\
+	A[B+3] = (uint8_t) ((C>>24) & 0xff);			\
+} while (0)
 
 // Reset the state to the empty message.
-#define MichaelClear( A ) 	A->L = A->K0; \
-				A->R = A->K1; \
-				A->nBytesInM = 0;
+#define MichaelClear(A)			\
+do {					\
+	A->L = A->K0;			\
+	A->R = A->K1;			\
+	A->nBytesInM = 0;		\
+} while (0)
 
 static
 void MichaelInitializeFunction(struct michel_mic_t *Mic, uint8_t * key)
-- 
2.1.0