lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jul 2016 11:24:09 +0200 From: Stanislaw Gruszka <sgruszka@...hat.com> To: "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com> Cc: "prarit@...hat.com" <prarit@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linuxwifi <linuxwifi@...el.com>, "Coelho, Luciano" <luciano.coelho@...el.com>, "Berg, Johannes" <johannes.berg@...el.com>, "kvalo@...eaurora.org" <kvalo@...eaurora.org>, "Ivgi, Chaya Rachel" <chaya.rachel.ivgi@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Sharon, Sara" <sara.sharon@...el.com>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org> Subject: Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded On Mon, Jul 11, 2016 at 06:27:30PM +0000, Grumbach, Emmanuel wrote: > I guess that works, but it seems wrong to me. Usually, registration > should happen only upon INIT, and yes, at that time the firmware is not > ready to provide the information yet. <snip> > > > > As can be seen in the current code base, iwl_mvm_tzone_get_temp() > > will return > > -EIO 100% of the time when the firmware doesn't support reading the If I understad correctly this error happen 100% of the time, not only during init. Hence seems there is an issue here, i.e. cur_ucode is not marked correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the time (iwl_mvm_is_tt_in_fw() incorrecly return true on Prarit device ? ). BTW, you implement thermal_zone device, but do you also need hwmon device? Perhaps using theramal_zone_params no_hwmon option would be proper here? Stanislaw
Powered by blists - more mailing lists