linux-kernel - RE: [PATCH] mpt3sas: Fix panic when aer correct error occured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ff4138de974ecb0307f283402235e5d@mail.gmail.com>
Date:	Thu, 14 Jul 2016 16:19:02 +0530
From:	Chaitra Basappa <chaitra.basappa@...adcom.com>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>,
	martin.petersen@...cle.com,
	Suganath Prabu Subramani 
	<suganath-prabu.subramani@...adcom.com>,
	PDL-MPT-FUSIONLINUX <mpt-fusionlinux.pdl@...adcom.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	guohanjun@...wei.com,
	Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>
Subject: RE: [PATCH] mpt3sas: Fix panic when aer correct error occured

Hi,
 Please consider this patch as Acked-by: Chaitra P B
<chaitra.basappa@...adcom.com>

Thanks,
 Chaitra

-----Original Message-----
From: Kefeng Wang [mailto:wangkefeng.wang@...wei.com]
Sent: Tuesday, July 12, 2016 3:13 PM
To: martin.petersen@...cle.com; suganath-prabu.subramani@...adcom.com;
MPT-FusionLinux.pdl@...adcom.com
Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org;
guohanjun@...wei.com; Kefeng Wang; Sathya Prakash; Chaitra P B
Subject: [PATCH] mpt3sas: Fix panic when aer correct error occured

The _scsih_pci_mmio_enabled called if scsih_pci_error_detected returns
PCI_ERS_RESULT_CAN_RECOVER, at this point, read/write to the device still
works, no need to reset slot.

Or the mpt3sas_base_map_resources in scsih_pci_slot_reset will fail, and
iounamp ioc->chip, then we will meet issue when read ioc->chip in
mpt3sas_base_get_iocstate from _base_fault_reset_work.

Cc: Sathya Prakash <sathya.prakash@...adcom.com>
Cc: Chaitra P B <chaitra.basappa@...adcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@...adcom.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
---

NOTE: I found this with an earlier kernel version, but the logic is not
changed.

 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 6bff13e..eedd62e3 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -9033,8 +9033,11 @@ scsih_pci_mmio_enabled(struct pci_dev *pdev)

 	/* TODO - dump whatever for debugging purposes */

-	/* Request a slot reset. */
-	return PCI_ERS_RESULT_NEED_RESET;
+	/* This called only if scsih_pci_error_detected returns
+	 * PCI_ERS_RESULT_CAN_RECOVER, read/write to the device
+	 * still works, not need to reset slot.
+	 */
+	return PCI_ERS_RESULT_RECOVERED;
 }

 /*
--
1.7.12.4