linux-kernel - Re: [PATCH v2] locking/pvqspinlock: restore/set vcpu_hashed state after failing adaptive locking spinning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANRm+Cwnr22sbsYWo+y9Epn8cUgMQghvnLMuY8B6Nf32zp2ukQ@mail.gmail.com>
Date:	Thu, 14 Jul 2016 19:28:45 +0800
From:	Wanpeng Li <kernellwp@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Wanpeng Li <wanpeng.li@...mail.com>,
	Ingo Molnar <mingo@...nel.org>,
	Waiman Long <Waiman.Long@....com>,
	Davidlohr Bueso <dave@...olabs.net>
Subject: Re: [PATCH v2] locking/pvqspinlock: restore/set vcpu_hashed state
 after failing adaptive locking spinning

2016-07-14 19:26 GMT+08:00 Peter Zijlstra <peterz@...radead.org>:
> On Thu, Jul 14, 2016 at 04:15:56PM +0800, Wanpeng Li wrote:
>> In this case, lock holder inserts the pv_node of queue head into the
>> hash table and set _Q_SLOW_VAL unnecessary. This patch avoids it by
>> restoring/setting vcpu_halted state after failing adaptive locking
>                         ^^^^^^
>> spinning.
>>
>
>> -             WRITE_ONCE(pn->state, vcpu_halted);
>> +             WRITE_ONCE(pn->state, vcpu_hashed);
>                                            ^^^^^^
>
> The Changelog meant so say vcpu_hashed, surely?

Oh, there is a typo in changelog, I will fix it.

Regards,
Wanpeng Li