linux-kernel - Re: [PATCH] ovl: fix link error without POSIX ACL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegtdGL1+ZeEUbLHgdQjQUWprYM=OqsZyU+sLsJp-vftPyQ@mail.gmail.com>
Date:	Thu, 14 Jul 2016 14:16:01 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Konstantin Khlebnikov <khlebnikov@...dex-team.ru>,
	Vivek Goyal <vgoyal@...hat.com>,
	"linux-unionfs@...r.kernel.org" <linux-unionfs@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ovl: fix link error without POSIX ACL

On Thu, Jul 14, 2016 at 11:54 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The latest fix for ACL on overlayfs introduced a link error:
>
> fs/built-in.o: In function `ovl_posix_acl_xattr_set':
> file.c:(.text+0x6b320): undefined reference to `posix_acl_from_xattr'
>
> posix_acl_from_xattr doesn't have a 'static inline' implementation when
> CONFIG_FS_POSIX_ACL is disabled, and I could not come up with an obvious
> way to do it.
>
> This instead avoids the link error by defining two sets of ACL operations
> and letting the compiler drop one of the two at compile time depending
> on CONFIG_FS_POSIX_ACL. This avoids all references to the ACL code,
> also leading to smaller code.

Thanks, pushed.

Miklos