linux-kernel - Re: [patch 1/2] drivers/virt: fix the error handling in ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160714125949.GB21281@gmail.com>
Date:	Thu, 14 Jul 2016 14:59:49 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Dave Hansen <dave.hansen@...ux.intel.com>,
	Timur Tabi <timur@...escale.com>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch 1/2] drivers/virt: fix the error handling in
 ioctl_dtprop()


* Dan Carpenter <dan.carpenter@...cle.com> wrote:

> If strndup_user() user fails then it returns an error pointer and we
> pass that to kfree() which causes an oops.

Hm, in addition to this fix wouldn't it be better to not crash if kfree() gets 
passed an error pointer? Would that have changed the pattern of this particular 
bug?

Thanks,

	Ingo