[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160714131249.GJ3847@xsjsorenbubuntu>
Date: Thu, 14 Jul 2016 06:12:49 -0700
From: Sören Brinkmann <soren.brinkmann@...inx.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC: <bhelgaas@...gle.com>, <michal.simek@...inx.com>,
<bharat.kumar.gogada@...inx.com>, <rgummal@...inx.com>,
<arnd@...db.de>, <jiang.liu@...ux.intel.com>,
<grygorii.strashko@...com>, <russell.joyce@...k.ac.uk>,
<lorenzo.pieralisi@....com>, <linux-pci@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] PCI: xilinx: Fix return value in case of error
On Thu, 2016-07-14 at 12:10:46 +0200, Christophe JAILLET wrote:
> In function 'xilinx_pcie_init_irq_domain', the pattern used to check and
> return error is:
>
> if (!var) {
> dev_err(...);
> return PTR_ERR(var);
> }
>
> So the returned value in case of error is always 0, which means 'success'.
> Change it to return -ENODEV instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Acked-by: Sören Brinkmann <soren.brinkmann@...inx.com>
Sören
Powered by blists - more mailing lists