linux-kernel - Re: [PATCH] media: s5p-mfc remove unnecessary error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5787951B.2050401@osg.samsung.com>
Date:	Thu, 14 Jul 2016 07:35:23 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Javier Martinez Canillas <javier@....samsung.com>,
	kyungmin.park@...sung.com, k.debski@...sung.com,
	jtp.park@...sung.com, mchehab@...nel.org
Cc:	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] media: s5p-mfc remove unnecessary error messages

On 07/14/2016 06:46 AM, Javier Martinez Canillas wrote:
> Hello Shuah,
> 
> On 07/12/2016 08:33 PM, Shuah Khan wrote:
>> Removing unnecessary error messages as appropriate error code is returned.
>>
>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>> ---
>>  drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
>> index b6fde20..906f80c 100644
>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
>> @@ -759,7 +759,6 @@ static int s5p_mfc_open(struct file *file)
>>  	/* Allocate memory for context */
>>  	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>>  	if (!ctx) {
>> -		mfc_err("Not enough memory\n");
> 
> I agree to remove this since in case of a OOM, the core already does a
> stack dump and prints an error message so there's no need to it here.
> 
>>  		ret = -ENOMEM;
>>  		goto err_alloc;
>>  	}
>> @@ -776,7 +775,6 @@ static int s5p_mfc_open(struct file *file)
>>  	while (dev->ctx[ctx->num]) {
>>  		ctx->num++;
>>  		if (ctx->num >= MFC_NUM_CONTEXTS) {
>> -			mfc_err("Too many open contexts\n");
> 
> But I think this error message shouldn't be removed since explains why
> the open failed, even when an error code is returned.

This message isn't very informative and not sure if it is giving
any more information than EBUSY. It is a good debug message perhaps,
but not an error message. Would it be okay if I made it debug instead.

thanks,
-- Shuah
> 
>>  			ret = -EBUSY;
>>  			goto err_no_ctx;
>>  		}
>>
> 
> Best regards,
>