linux-kernel - Re: [PATCH] usb: ehci-platform: use helper variables in probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Jul 2016 17:22:38 +0200
From:	Rafał Miłecki <zajec5@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tony Prisk <linux@...sktech.co.nz>,
	"moderated list:ARM/VT8500 ARM ARCHITECTURE" 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:USB EHCI DRIVER" <linux-usb@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: ehci-platform: use helper variables in probe function

On 14 July 2016 at 16:11, Alan Stern <stern@...land.harvard.edu> wrote:
> On Wed, 13 Jul 2016, Rafał Miłecki wrote:
>
>> Probing function was using &dev->dev and dev->dev.of_node over 20 times
>> so I believe it made sense to use helper variables for both of them.
>> To avoid some uncommon variable name for struct device I first replaced
>> existing dev variable with pdev.
>>
>> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
>
> Okay except for...
>
>> -             priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
>> -                             "phys", "#phy-cells");
>> +             priv->num_phys = of_count_phandle_with_args(np, "phys",
>> +                                                         "#phy-cells");
>
> Please indent continuation lines two tab stops beyond the original
> line, to match the style in the rest of the source file.

I'm afraid this file doesn't have any consistent coding style for line breaks.

1) dma_coerce_mask_and_coherent
One extra tab after line break.

2) devm_kcalloc
Two extra tabs and 4 spaces. No real alignment noticed.

3) devm_of_phy_get_by_index
Two extra tabs

4) devm_reset_control_get_shared_by_index
Three extra tabs

With these pointed, do you still think I should use two extra tabs? If
so, I'll send V2 as you suggested. Just let me know.

-- 
Rafał