linux-kernel - Re: [PATCH v3 2/2] ASoC: atmel-i2s: add driver for the new Atmel I2S controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160714162059.GB30372@sirena.org.uk>
Date:	Thu, 14 Jul 2016 17:20:59 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Cyrille Pitchen <cyrille.pitchen@...el.com>
Cc:	nicolas.ferre@...el.com, lgirdwood@...il.com,
	alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/2] ASoC: atmel-i2s: add driver for the new Atmel I2S
 controller

On Wed, Jul 13, 2016 at 12:25:39PM +0200, Cyrille Pitchen wrote:

A few small things but otherwise this looks good:

> +	switch (params_channels(params)) {
> +	case 1:
> +		mr |= is_playback ? ATMEL_I2SC_MR_TXMONO : ATMEL_I2SC_MR_RXMONO;

Please write normal if statements, it makes things easier to read.

> +		break;
> +	case 2:
> +		break;
> +	default:
> +		dev_err(dev->dev, "unsupported number of audio channels\n");
> +		break;
> +	}

Why don't we return an error if we don't support the requested number of
channels?

> +	dev->gclk = devm_clk_get(&pdev->dev, "gclk");
> +	if (IS_ERR(dev->aclk) && IS_ERR(dev->gclk)) {
> +		/* Master Mode not supported */
> +		dev->aclk = NULL;
> +		dev->gclk = NULL;

This won't handle probe deferral properly, it'll just ignore the clocks
if we get -EPROBE_DEFER.  The driver should special case that at least.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)