| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160714164732.GA2963@amitoj-Inspiron-3542> Date: Thu, 14 Jul 2016 22:17:32 +0530 From: Amitoj Kaur Chawla <amitoj1606@...il.com> To: Julia.Lawall@...6.fr, Gilles.Muller@...6.fr, nicolas.palix@...g.fr, mmarek@...e.com, cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org Subject: [PATCH] Coccinelle: Script to use roundup and DIV_ROUND_UP This script replaces manual calculations by using the predefined macros in kernel.h, DIV_ROUND_UP and roundup for readability purposes. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com> --- scripts/coccinelle/api/roundup.cocci | 215 +++++++++++++++++++++++++++++++++++ 1 file changed, 215 insertions(+) create mode 100644 scripts/coccinelle/api/roundup.cocci diff --git a/scripts/coccinelle/api/roundup.cocci b/scripts/coccinelle/api/roundup.cocci new file mode 100644 index 0000000..af97cd2 --- /dev/null +++ b/scripts/coccinelle/api/roundup.cocci @@ -0,0 +1,215 @@ +/// Use DIV_ROUND_UP and roundup to improve readability +/// +// Confidence: High +// Copyright: (C) 2016 Amitoj Kaur Chawla + +virtual patch +virtual context +virtual org +virtual report + +@...kernel@ +@@ + +#include <linux/kernel.h> + +@...nd1 depends on haskernel && patch && !context && !org && !report@ +expression x, y; +@@ + +( +- (((x + (y - 1)) / y) * y) ++ roundup(x, y) +| +- (((x + y - 1) / y) * y) ++ roundup(x, y) +) + +@...nd2 depends on haskernel && patch && !context && !org && !report + disable paren@ +expression x, y; +@@ + +- roundup((x), y) ++ roundup(x, y) + +@...nd3 depends on haskernel && patch && !context && !org && !report + disable paren@ +expression x, y; +@@ + +- roundup(x, (y)) ++ roundup(x, y) + +@...nd4 depends on haskernel && patch && !context && !org && !report@ +expression n,d; +@@ + +( +- ((n + d - 1) / d) ++ DIV_ROUND_UP(n,d) +| +- ((n + (d - 1)) / d) ++ DIV_ROUND_UP(n,d) +) + +@...nd5 depends on haskernel && patch && !context && !org && !report + disable paren@ +expression n,d; +@@ + +- DIV_ROUND_UP((n),d) ++ DIV_ROUND_UP(n,d) + +@...nd6 depends on haskernel && patch && !context && !org && !report + disable paren@ +expression n,d; +@@ + +- DIV_ROUND_UP(n,(d)) ++ DIV_ROUND_UP(n,d) + +// ---------------------------------------------------------------------------- + +@...nd1_context depends on haskernel && !patch && (context || org || report)@ +expression e, x, y; +position j,j0; +@@ + +( +* (((x@j + (y - 1)) / y) *@e@j0 y) +| +* (((x@j + y - 1) / y) *@e@j0 y) +) + +@...nd2_context depends on haskernel && !patch && (context || org || report) + disable paren@ +expression x, y; +position j0; +@@ + +* roundup@j0((x), y) + +@...nd3_context depends on haskernel && !patch && (context || org || report) + disable paren@ +expression x, y; +position j0; +@@ + +* roundup@j0(x, (y)) + +@...nd4_context depends on haskernel && !patch && (context || org || report)@ +expression e, d, n; +position j!=round1_context.j; +position j0; +@@ + +( +* ((n@j + d - 1) /@e@j0 d) +| +* ((n@j + (d - 1)) /@e@j0 d) +) + +@...nd5_context depends on haskernel && !patch && (context || org || report) + disable paren@ +expression d, n; +position j0; +@@ + +* DIV_ROUND_UP@j0((n),d) + +@...nd6_context depends on haskernel && !patch && (context || org || report) + disable paren@ +expression d, n; +position j0; +@@ + +* DIV_ROUND_UP@j0(n,(d)) + +// ---------------------------------------------------------------------------- + +@...ipt:python round1_org depends on org@ +j0 << round1_context.j0; +@@ + +msg = "WARNING: Replace with roundup." +coccilib.org.print_todo(j0[0], msg) + +@...ipt:python round2_org depends on org@ +j0 << round2_context.j0; +@@ + +msg = "WARNING: Unneeded parentheses in the first argument of roundup." +coccilib.org.print_todo(j0[0], msg) + +@...ipt:python round3_org depends on org@ +j0 << round3_context.j0; +@@ + +msg = "WARNING: Unneeded parentheses in the second argument of roundup." +coccilib.org.print_todo(j0[0], msg) + +@...ipt:python round4_org depends on org@ +j0 << round4_context.j0; +@@ + +msg = "WARNING: Replace with DIV_ROUND_UP." +coccilib.org.print_todo(j0[0], msg) + +@...ipt:python round5_org depends on org@ +j0 << round5_context.j0; +@@ + +msg = "WARNING: Unneeded parentheses in the first argument of DIV_ROUND_UP." +coccilib.org.print_todo(j0[0], msg) + +@...ipt:python round6_org depends on org@ +j0 << round6_context.j0; +@@ + +msg = "WARNING: Unneeded parentheses in the second argument of DIV_ROUND_UP." +coccilib.org.print_todo(j0[0], msg) + +// ---------------------------------------------------------------------------- + +@...ipt:python round1_report depends on report@ +j0 << round1_context.j0; +@@ + +msg = "WARNING: Replace with roundup." +coccilib.report.print_report(j0[0], msg) + +@...ipt:python round2_report depends on report@ +j0 << round2_context.j0; +@@ + +msg = "WARNING: Unneeded parentheses in the first argument of roundup." +coccilib.report.print_report(j0[0], msg) + +@...ipt:python round3_report depends on report@ +j0 << round3_context.j0; +@@ + +msg = "WARNING: Unneeded parentheses in the second argument of roundup." +coccilib.report.print_report(j0[0], msg) + +@...ipt:python round4_report depends on report@ +j0 << round4_context.j0; +@@ + +msg = "WARNING: Replace with DIV_ROUND_UP." +coccilib.report.print_report(j0[0], msg) + +@...ipt:python round5_report depends on report@ +j0 << round5_context.j0; +@@ + +msg = "WARNING: Unneeded parentheses in the first argument of DIV_ROUND_UP." +coccilib.report.print_report(j0[0], msg) + +@...ipt:python round6_report depends on report@ +j0 << round6_context.j0; +@@ + +msg = "WARNING: Unneeded parentheses in the second argument of DIV_ROUND_UP." +coccilib.report.print_report(j0[0], msg) -- 1.9.1
Powered by blists - more mailing lists