linux-kernel - Re: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89c61610-47f0-bfab-0642-7152f90936e8@infradead.org>
Date:	Thu, 14 Jul 2016 10:07:33 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:	davem@...emloft.net, arnd@...db.de, linux-kernel@...r.kernel.org,
	idosch@...lanox.com, yotamg@...lanox.com, eladr@...lanox.com,
	nogahf@...lanox.com, ogerlitz@...lanox.com, ivecera@...hat.com,
	rostedt@...dmis.org, mingo@...hat.com, jolsa@...nel.org
Subject: Re: [patch net-next 1/2] tracing: change owner name to driver name
 for devlink hwmsg tracepoint

On 07/14/16 02:37, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> Turned on that driver->owner which is struct module is not available when
> modules are disabled. Better to depend on a driver name which is
> always available.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Fixes: e5224f0fe2 ("devlink: add hardware messages tracing facility")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  include/trace/events/devlink.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h
> index 333c32a..77dce71 100644
> --- a/include/trace/events/devlink.h
> +++ b/include/trace/events/devlink.h
> @@ -22,7 +22,7 @@ TRACE_EVENT(devlink_hwmsg,
>  	TP_STRUCT__entry(
>  		__string(bus_name, devlink->dev->bus->name)
>  		__string(dev_name, dev_name(devlink->dev))
> -		__string(owner_name, devlink->dev->driver->owner->name)
> +		__string(driver_name, devlink->dev->driver->name)
>  		__field(bool, incoming)
>  		__field(unsigned long, type)
>  		__dynamic_array(u8, buf, len)
> @@ -32,16 +32,16 @@ TRACE_EVENT(devlink_hwmsg,
>  	TP_fast_assign(
>  		__assign_str(bus_name, devlink->dev->bus->name);
>  		__assign_str(dev_name, dev_name(devlink->dev));
> -		__assign_str(owner_name, devlink->dev->driver->owner->name);
> +		__assign_str(driver_name, devlink->dev->driver->name);
>  		__entry->incoming = incoming;
>  		__entry->type = type;
>  		memcpy(__get_dynamic_array(buf), buf, len);
>  		__entry->len = len;
>  	),
>  
> -	TP_printk("bus_name=%s dev_name=%s owner_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%lu",
> +	TP_printk("bus_name=%s dev_name=%s driver_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%lu",
>  		  __get_str(bus_name), __get_str(dev_name),
> -		  __get_str(owner_name), __entry->incoming, __entry->type,
> +		  __get_str(driver_name), __entry->incoming, __entry->type,
>  		  (int) __entry->len, __get_dynamic_array(buf), __entry->len)
>  );
>  
> 


-- 
~Randy