lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jul 2016 10:54:45 -0700 From: Tai Tri Nguyen <ttnguyen@....com> To: Joe Perches <joe@...ches.com> Cc: Mark Rutland <mark.rutland@....com>, Will Deacon <will.deacon@....com>, catalin.marinas@....com, Paul Gortmaker <paul.gortmaker@...driver.com>, Duc Dang <dhdang@....com>, LKML <linux-kernel@...r.kernel.org>, devicetree@...r.kernel.org, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, patches <patches@....com> Subject: Re: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver Hi Joe, On Thu, Jul 14, 2016 at 10:47 AM, Joe Perches <joe@...ches.com> wrote: > On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote: >> This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware >> found in APM X-Gene SoCs. > > trivia: > >> diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c > [] >> +struct xgene_pmu_dev_ctx { >> + char *name; >> + struct list_head next; >> + struct xgene_pmu_dev *pmu_dev; >> + struct hw_pmu_info inf; >> +}; > > Probably better to use something like > char name[20]; > as the kasprintf can fail and this doesn't > seem to be freed anywhere. Okay. I'll fix it shortly. [...] Thanks, -- Tai
Powered by blists - more mailing lists