linux-kernel - Re: [PATCH v5 01/32] bluetooth: Switch SMP to crypto_cipher_encrypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160714.134144.1427497707130106328.davem@davemloft.net>
Date:	Thu, 14 Jul 2016 13:41:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	luto@...capital.net
Cc:	luto@...nel.org, x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, bp@...en8.de, nadav.amit@...il.com,
	keescook@...omium.org, brgerst@...il.com,
	kernel-hardening@...ts.openwall.com, torvalds@...ux-foundation.org,
	jpoimboe@...hat.com, jann@...jh.net, heiko.carstens@...ibm.com,
	marcel@...tmann.org, gustavo@...ovan.org, johan.hedberg@...il.com,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v5 01/32] bluetooth: Switch SMP to
 crypto_cipher_encrypt_one()

From: Andy Lutomirski <luto@...capital.net>
Date: Thu, 14 Jul 2016 12:10:45 -0700

> On Mon, Jul 11, 2016 at 1:53 PM, Andy Lutomirski <luto@...nel.org> wrote:
>> SMP does ECB crypto on stack buffers.  This is complicated and
>> fragile, and it will not work if the stack is virtually allocated.
>>
>> Switch to the crypto_cipher interface, which is simpler and safer.
> 
> Hi Dave-
> 
> It looks like we're delaying virtually mapped stacks to 4.9.  That
> means that there's time for this to go in through net-next.  Could you
> queue it up?

This needs to go via the bluetooth maintainer, who will surely pass
it properly my way.