linux-kernel - Re: [PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Jul 2016 22:20:48 +0100
From:	Emil Velikov <emil.l.velikov@...il.com>
To:	Vinay Simha BN <simhavcs@...il.com>
Cc:	open list <linux-kernel@...r.kernel.org>,
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
	Archit Taneja <archit.taneja@...il.com>
Subject: Re: [PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness

On 13 July 2016 at 17:44, Vinay Simha BN <simhavcs@...il.com> wrote:

> +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,
> +                                       u16 *brightness)
> +{
> +       ssize_t err;
> +
> +       err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS,
> +                               brightness, sizeof(*brightness));
> +       if (err < 0) {
> +               if (err == 0)
Something looks fishy here. This can never be true, can it ?

 -Emil