linux-kernel - Re: [RESEND PATCH 11/14] eeprom: at24: add the at24cs series to the list of supported devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160715063047.GA7675@tetsubishi>
Date:	Fri, 15 Jul 2016 15:30:48 +0900
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:	linux-i2c <linux-i2c@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Lunn <andrew@...n.ch>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	GregKH <greg@...ah.com>
Subject: Re: [RESEND PATCH 11/14] eeprom: at24: add the at24cs series to the
 list of supported devices

>  	{ "24c01",	AT24_DEVICE_MAGIC(1024 / 8,	0) },
> +	{ "24cs01",	AT24_DEVICE_MAGIC(128 / 8,

I encoded the size for EEPROMs with "x / 8" originally to make it
visible where the EEPROM name came from, i.e. that is from kilobits not
kilobytes. So, for the serial number I would simply encode the size as
16 and not as (128 / 8), because it has nothing to do with the name. I
can fix this locally if you are okay with the idea?

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)