linux-kernel - Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160715071309.GF817@shlinux2>
Date:	Fri, 15 Jul 2016 15:13:09 +0800
From:	Peter Chen <hzpeterchen@...il.com>
To:	Rajesh Bhagat <rajesh.bhagat@....com>
Cc:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Peter Chen <peter.chen@....com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"kishon@...com" <kishon@...com>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote:
> > > +
> > > +err_clks:
> > > +	ci_hdrc_qoriq_disable_unprepare_clks(pdev);
> > 
> > If you have only one clock, it is unnecessary to use dedicated APIs for clock operation.
> > 
> 
> We do have multiple clocks, but currently one is integrated in code. Hence created 
> the APIs for future use. 

If you could not integrate one more clocks, I suggest not creating dedicated
API until you need in future.

-- 

Best Regards,
Peter Chen