linux-kernel - RE: [PATCH V1] regulator: da9210: addition of device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ED8E3B22081A4459DAC7699F3695FB70173DAB217@SW-EX-MBX02.diasemi.com>
Date:	Fri, 15 Jul 2016 09:17:39 +0000
From:	Steve Twiss <stwiss.opensource@...semi.com>
To:	Mark Brown <broonie@...nel.org>
CC:	DEVICETREE <devicetree@...r.kernel.org>,
	LINUXKERNEL <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	"Mark Rutland" <mark.rutland@....com>,
	Rob Herring <robh+dt@...nel.org>,
	"Support Opensource" <Support.Opensource@...semi.com>
Subject: RE: [PATCH V1] regulator: da9210: addition of device tree support

On 14 July 2016 16:48, Mark Brown wrote:

> To: Steve Twiss
> Cc: DEVICETREE; LINUXKERNEL; Liam Girdwood; Mark Rutland; Rob Herring;
> Support Opensource
> Subject: Re: [PATCH V1] regulator: da9210: addition of device tree support
> 
> On Wed, Jul 13, 2016 at 04:41:19PM +0100, Steve Twiss wrote:
> 
> > Two files are modified, the driver source file and the binding document.
> > Updates for the regulator source file include an .of_match_table entry, node
> > match checking in the probe() function for a compatible da9210 string, and
> > a new "BUCK" regulator entry. The binding documentation changes have been
> > made to reflect these updates.
> 
> If the device only has one regulator and no other functionality I'd
> expect the properties to just be in the top level node for the device -
> no need to go fiddling around with a subnode to hold another subnode to
> hold all the properties.

Agreed.
I will revert those changes to the device tree and re-submit V2.