linux-kernel - Re: [PATCH 21/36] usb: serial: ti_usb_3410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160715120840.GL8809@localhost>
Date:	Fri, 15 Jul 2016 14:08:40 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Mathieu OTHACEHE <m.othacehe@...il.com>
Cc:	johan@...nel.org, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/36] usb: serial: ti_usb_3410_5052: Use generic close
 function

On Thu, May 12, 2016 at 10:48:53AM +0200, Mathieu OTHACEHE wrote:
> Use usb_serial_generic_close in close callback.
>
> Signed-off-by: Mathieu OTHACEHE <m.othacehe@...il.com>
> ---
>  drivers/usb/serial/ti_usb_3410_5052.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
> index 8350c6b..3d36ae7 100644
> --- a/drivers/usb/serial/ti_usb_3410_5052.c
> +++ b/drivers/usb/serial/ti_usb_3410_5052.c
> @@ -807,24 +807,16 @@ static void ti_close(struct usb_serial_port *port)
>  {
>  	struct ti_device *tdev;
>  	struct ti_port *tport;
> -	int port_number;
>  	int status;
>  	int do_unlock;
> -	unsigned long flags;
>  
>  	tdev = usb_get_serial_data(port->serial);
>  	tport = usb_get_serial_port_data(port);
>  
> -	usb_kill_urb(port->read_urb);
> -	usb_kill_urb(port->write_urb);
> -	spin_lock_irqsave(&tport->tp_lock, flags);
> -	kfifo_reset_out(&port->write_fifo);
> -	spin_unlock_irqrestore(&tport->tp_lock, flags);
> -
> -	port_number = port->port_number;
> +	usb_serial_generic_close(port);

This change must go with the conversion to use the generic
implementations (e.g. in order to kill both read urbs at close, etc).

Thanks,
Johan