linux-kernel - Re: [PATCH 06/16] gpu: ipu-v3: Add ipu_set_vdi_src

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1468586926.7213.36.camel@pengutronix.de>
Date:	Fri, 15 Jul 2016 14:48:46 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Steve Longerbeam <slongerbeam@...il.com>
Cc:	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Steve Longerbeam <steve_longerbeam@...tor.com>
Subject: Re: [PATCH 06/16] gpu: ipu-v3: Add ipu_set_vdi_src_mux()

Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam:
> Adds ipu_set_vdi_src_mux() that selects the VDIC input
> (from CSI or memory).
> 
> Signed-off-by: Steve Longerbeam <steve_longerbeam@...tor.com>
> ---
>  drivers/gpu/ipu-v3/ipu-common.c | 20 ++++++++++++++++++++
>  include/video/imx-ipu-v3.h      |  1 +
>  2 files changed, 21 insertions(+)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> index 6d1676e..374100e 100644
> --- a/drivers/gpu/ipu-v3/ipu-common.c
> +++ b/drivers/gpu/ipu-v3/ipu-common.c
> @@ -730,6 +730,26 @@ void ipu_set_ic_src_mux(struct ipu_soc *ipu, int csi_id, bool vdi)
>  }
>  EXPORT_SYMBOL_GPL(ipu_set_ic_src_mux);
>  
> +/*
> + * Set the source for the VDIC. Selects either from CSI[01] or memory.
> + */
> +void ipu_set_vdi_src_mux(struct ipu_soc *ipu, bool csi)
> +{
> +	unsigned long flags;
> +	u32 val;
> +
> +	spin_lock_irqsave(&ipu->lock, flags);
> +
> +	val = ipu_cm_read(ipu, IPU_FS_PROC_FLOW1);
> +	val &= ~(0x3 << 28);
> +	if (csi)
> +		val |= (0x01 << 28);

This doesn't set a bus mux, or does it? As I understand it, this
configures the FSU to trigger the VDIC conversion from the CSI direct
channel sync signals (IC channel CB7). As such I believe this belongs
together with the other channel linking code, maybe even in ipu-fsu.c.

Also, some #defines would be nice, for example:

#define FS_VDI_SRC_SEL_MASK		(0x3 << 28)
#define FS_VDI_SRC_SEL_OFFSET		28
#define FS_VDI_SRC_SEL_CSI_DIRECT	0x1
#define FS_VDI_SRC_SEL_VDOA		0x2

regards
Philipp