linux-kernel - Re: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

Open Source and information security mailing list archives

Message-ID: <CADnq5_O-goY0xKa4sSkJYn=zth-bqxUooEC+_PHzAcFu_A7b=A@mail.gmail.com>
Date:	Fri, 15 Jul 2016 11:46:26 -0400
From:	Alex Deucher <alexdeucher@...il.com>
To:	Matthias Beyer <mail@...ermatthias.de>
Cc:	"Zhu, Rex" <Rex.Zhu@....com>,
	"nils.wallmenius@...il.com" <nils.wallmenius@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linuxdev.baldrick@...il.com" <linuxdev.baldrick@...il.com>,
	"Huang, JinHuiEric" <JinHuiEric.Huang@....com>,
	"dcb314@...mail.com" <dcb314@...mail.com>,
	"Deucher, Alexander" <Alexander.Deucher@....com>,
	"Koenig, Christian" <Christian.Koenig@....com>
Subject: Re: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

On Thu, Jul 14, 2016 at 1:22 PM, Matthias Beyer <mail@...ermatthias.de> wrote:
> Hi list,
>
> I just wondered: I send the patch >14 days ago, 9 days ago it was
> reviewed by Rex Zhu. As far as I know, it isn't applied by now. At
> least I did not get a mail indicating that it was applied.
>
> Are there issues with the patch I missed?

Applied.  Sorry for the delay.

Alex

>
> On 05-07-2016 15:06:59, Zhu, Rex wrote:
>>
>> Yes, stretch_amount2 was not used on Polaris.
>>
>>
>> Patch was Reviewed-by: Rex Zhu <Rex.Zhu@....com>
>>
>>
>> Thanks.
>>
>>
>> Best Regards
>>
>> Rex
>>
>> ________________________________
>> From: Matthias Beyer <mail@...ermatthias.de>
>> Sent: Friday, July 1, 2016 12:38:49 AM
>> To: linuxdev.baldrick@...il.com
>> Cc: Deucher, Alexander; Koenig, Christian; airlied@...ux.ie; dri-devel@...ts.freedesktop.org; dcb314@...mail.com; linux-kernel@...r.kernel.org; Zhu, Rex; Huang, JinHuiEric; nils.wallmenius@...il.com; Matthias Beyer
>> Subject: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable
>>
>> Signed-off-by: Matthias Beyer <mail@...ermatthias.de>
>> ---
>>  drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
>>  1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
>> index 64ee78f..1dcd52d 100644
>> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
>> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
>> @@ -1761,7 +1761,7 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>>  {
>>          uint32_t ro, efuse, volt_without_cks, volt_with_cks, value, max, min;
>>          struct polaris10_hwmgr *data = (struct polaris10_hwmgr *)(hwmgr->backend);
>> -       uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0;
>> +       uint8_t i, stretch_amount, volt_offset = 0;
>>          struct phm_ppt_v1_information *table_info =
>>                          (struct phm_ppt_v1_information *)(hwmgr->pptable);
>>          struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =
>> @@ -1806,11 +1806,8 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>>          }
>>
>>          /* Populate CKS Lookup Table */
>> -       if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5)
>> -               stretch_amount2 = 0;
>> -       else if (stretch_amount == 3 || stretch_amount == 4)
>> -               stretch_amount2 = 1;
>> -       else {
>> +       if (stretch_amount != 1 && stretch_amount != 2 && stretch_amount != 3 &&
>> +                       stretch_amount != 4 && stretch_amount != 5) {
>>                  phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
>>                                  PHM_PlatformCaps_ClockStretcher);
>>                  PP_ASSERT_WITH_CODE(false,
>> --
>> 2.9.0
>>
>
> --
> Mit freundlichen Grüßen,
> Kind regards,
> Matthias Beyer
>
> Proudly sent with mutt.
> Happily signed with gnupg.
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives