linux-kernel - Re: [PATCH 2/5] mm, vmscan: avoid passing in classzone_idx unnecessarily to compaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160715155053.GC8644@bbox>
Date:	Sat, 16 Jul 2016 00:50:53 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Mel Gorman <mgorman@...hsingularity.net>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Vlastimil Babka <vbabka@...e.cz>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] mm, vmscan: avoid passing in classzone_idx
 unnecessarily to compaction_ready -fix

On Fri, Jul 15, 2016 at 02:09:22PM +0100, Mel Gorman wrote:
> As pointed out by Vlastimil, there is a redundant check in shrink_zones
> since commit "mm, vmscan: avoid passing in classzone_idx unnecessarily to
> compaction_ready".  The zonelist iterator only returns zones that already
> meet the requirements of the allocation request.
> 
> This is a fix to the mmotm patch
> mm-vmscan-avoid-passing-in-classzone_idx-unnecessarily-to-compaction_ready.patch
> 
> Signed-off-by: Mel Gorman <mgorman@...hsingularity.net>
Acked-by: Minchan Kim <minchan@...nel.org>

Just a Nit:
It seems there is another redundant check in there.

shrink_zones
..
        for_each_zone_zonelist_nodemask(zone, z, zonelist,
                                        sc->reclaim_idx, sc->nodemask) {
                if (!populated_zone(zone)) <==
                        continue;

Of course, it's not your fault but it would be a good chance to
remove such trivial thing :)
If I don't miss something, I hope piggyback on this patch. Andrew?