linux-kernel - Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160715185009.GB13516@tuxbot>
Date:	Fri, 15 Jul 2016 11:50:09 -0700
From:	Bjorn Andersson <bjorn.andersson@...aro.org>
To:	Peter Chen <peter.chen@....com>
Cc:	lee.jones@...aro.org, linux-kernel@...r.kernel.org,
	Bjorn Andersson <bjorn.andersson@...ymobile.com>
Subject: Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling
 of_parse_phandle

On Fri 15 Jul 02:38 PDT 2016, Peter Chen wrote:

> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
> 
> Cc: Bjorn Andersson <bjorn.andersson@...ymobile.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> Cc: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Peter Chen <peter.chen@....com>
> ---
>  drivers/mfd/qcom_rpm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 2e44323..ecca115 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -538,6 +538,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  	}
>  
>  	rpm->ipc_regmap = syscon_node_to_regmap(syscon_np);
> +	of_node_put(syscon_np);
>  	if (IS_ERR(rpm->ipc_regmap))
>  		return PTR_ERR(rpm->ipc_regmap);
>  
> -- 
> 1.9.1
>