[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.10.1607151422140.121215@chino.kir.corp.google.com>
Date: Fri, 15 Jul 2016 14:25:22 -0700 (PDT)
From: David Rientjes <rientjes@...gle.com>
To: Mikulas Patocka <mpatocka@...hat.com>
cc: Michal Hocko <mhocko@...nel.org>,
Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
Ondrej Kozina <okozina@...hat.com>,
Jerome Marchand <jmarchan@...hat.com>,
Stanislav Kozina <skozina@...hat.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, dm-devel@...hat.com
Subject: Re: System freezes after OOM
On Fri, 15 Jul 2016, Mikulas Patocka wrote:
> > There is no guarantee that _anything_ can return memory to the mempool,
>
> You misunderstand mempools if you make such claims.
>
> There is in fact guarantee that objects will be returned to mempool. In
> the past I reviewed device mapper thoroughly to make sure that it can make
> forward progress even if there is no available memory.
>
> I don't know what should I tell you if you keep on repeating the same
> false claim over and over again. Should I explain mempool oprerations to
> you in detail? Or will you find it on your own?
>
If you are talking about patches you're proposing for 4.8 or any guarantee
of memory freeing that the oom killer/reaper will provide in 4.8, that's
fine. However, the state of the 4.7 kernel is the same as it was when I
fixed this issue that timed out hundreds of our machines and is
contradicted by that evidence. Our machines time out after two hours with
the oom victim looping forever in mempool_alloc(), so if there was a
guarantee that elements would be returned in a completely livelocked
kernel in 4.7 or earlier kernels, that would not have been the case. I
frankly don't care about your patch reviewing of dm mempool usage when
dm_request() livelocked our kernel.
Feel free to formally propose patches either for 4.7 or 4.8.
Powered by blists - more mailing lists