linux-kernel - Re: [patch] testing/radix-tree: fix a macro expansion bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160715214213.GA3883@linux.intel.com>
Date:	Fri, 15 Jul 2016 15:42:13 -0600
From:	Ross Zwisler <ross.zwisler@...ux.intel.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Matthew Wilcox <willy@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ross Zwisler <ross.zwisler@...ux.intel.com>,
	Konstantin Khlebnikov <koct9i@...il.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] testing/radix-tree: fix a macro expansion bug

On Sat, Jul 16, 2016 at 12:09:53AM +0300, Dan Carpenter wrote:
> There are no parentheses around this macro and it causes a problem when
> we do:
> 
> 	index = rand() % THRASH_SIZE;
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Ross Zwisler <ross.zwisler@...ux.intel.com>

> 
> diff --git a/tools/testing/radix-tree/tag_check.c b/tools/testing/radix-tree/tag_check.c
> index b7447ce..b0ac057 100644
> --- a/tools/testing/radix-tree/tag_check.c
> +++ b/tools/testing/radix-tree/tag_check.c
> @@ -122,7 +122,7 @@ enum {
>  	NODE_TAGGED = 2,
>  };
>  
> -#define THRASH_SIZE		1000 * 1000
> +#define THRASH_SIZE		(1000 * 1000)
>  #define N 127
>  #define BATCH	33
>