linux-kernel - Re: [PATCH net] net: nb8800: Fix SKB leak in nb8800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xd1mdg840.fsf@unicorn.mansr.com>
Date:	Sat, 16 Jul 2016 12:01:03 +0100
From:	Måns Rullgård <mans@...sr.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Sebastian Frias <sf84@...oste.net>,
	Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH net] net: nb8800: Fix SKB leak in nb8800_receive()

Florian Fainelli <f.fainelli@...il.com> writes:

> In case nb8800_receive() fails to allocate a fragment, we would leak the
> SKB freshly allocated and just return, instead, free it.
>
> Reported-by: coverity (CID 1341750)
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Acked-by: Mans Rullgard <mans@...sr.com>

> ---
>  drivers/net/ethernet/aurora/nb8800.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
> index 08a23e6b60e9..1a3555d03a96 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -259,6 +259,7 @@ static void nb8800_receive(struct net_device *dev, unsigned int i,
>  		if (err) {
>  			netdev_err(dev, "rx buffer allocation failed\n");
>  			dev->stats.rx_dropped++;
> +			dev_kfree_skb(skb);
>  			return;
>  		}
>
> -- 
> 2.7.4
>

-- 
Måns Rullgård