linux-kernel - Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs on compound page arrival"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.02.1607161448350.26056@file01.intranet.prod.int.rdu2.redhat.com>
Date:	Sat, 16 Jul 2016 14:48:47 -0400 (EDT)
From:	Mikulas Patocka <mpatocka@...hat.com>
To:	Jens Rottmann <jens.rottmann@...inktech.com>
cc:	Minchan Kim <minchan@...nel.org>,
	Lukasz Odzioba <lukasz.odzioba@...el.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Michal Hocko <mhocko@...e.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs
 on compound page arrival"



On Sat, 16 Jul 2016, Jens Rottmann wrote:

> Hi Minchan (& all),
> 
> Minchan Kim wrote:
> > [...] found __lru_cache_add has a bug. [...]
> [-]     if (!pagevec_space(pvec) || PageCompound(page))
> [+]     if (!pagevec_add(pvec, page) || PageCompound(page))
> 
> Confirm that did plug the leak, thanks!
> 
> Also I just saw this was known already:
> https://marc.info/?l=linux-kernel&m=146858368215856
> Sorry for not noticing earlier, I did search for "4.1.28 memory leak", but not for "memleak".
> 
> Many thanks,
> Jens

For me it fixed the bug too.

Mikulas