linux-kernel - Re: [patch] tools/vm/slabinfo: fix an unintentional printf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160716033419.GA493@swordfish>
Date:	Sat, 16 Jul 2016 12:34:19 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Lameter <cl@...ux.com>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Colin Ian King <colin.king@...onical.com>,
	Laura Abbott <labbott@...oraproject.org>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] tools/vm/slabinfo: fix an unintentional printf

On (07/16/16 00:12), Dan Carpenter wrote:
> The curly braces are missing here so we print stuff unintentionally.
> 
> Fixes: 9da4714a2d4f ('slub: slabinfo update for cmpxchg handling')

Hello,

a minor correction:
it's 	9da4714a2d44

not 	9da4714a2d4f

	-ss


> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
> index 7cf6e17..b9d34b3 100644
> --- a/tools/vm/slabinfo.c
> +++ b/tools/vm/slabinfo.c
> @@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *s)
>  			s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total);
>  	}
>  
> -	if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail)
> +	if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) {
>  		printf("\nCmpxchg_double Looping\n------------------------\n");
>  		printf("Locked Cmpxchg Double redos   %lu\nUnlocked Cmpxchg Double redos %lu\n",
>  			s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail);
> +	}
>  }
>  
>  static void report(struct slabinfo *s)
>