linux-kernel - Re: [PATCH] watchdog: pcwd: Utilize the module_isa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160717194959.GB32751@spo001.leaseweb.nl>
Date:	Sun, 17 Jul 2016 21:49:59 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	William Breathitt Gray <vilhelm.gray@...il.com>
Cc:	linux@...ck-us.net, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: pcwd: Utilize the module_isa_driver macro

Hi William,

> This driver does not do anything special in module init/exit. This patch
> eliminates the module init/exit boilerplate code by utilizing the
> module_isa_driver macro.
> 
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> ---
>  drivers/watchdog/pcwd.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/drivers/watchdog/pcwd.c b/drivers/watchdog/pcwd.c
> index e936f15..3ad5206 100644
> --- a/drivers/watchdog/pcwd.c
> +++ b/drivers/watchdog/pcwd.c
> @@ -992,19 +992,7 @@ static struct isa_driver pcwd_isa_driver = {
>  	},
>  };
>  
> -static int __init pcwd_init_module(void)
> -{
> -	return isa_register_driver(&pcwd_isa_driver, PCWD_ISA_NR_CARDS);
> -}
> -
> -static void __exit pcwd_cleanup_module(void)
> -{
> -	isa_unregister_driver(&pcwd_isa_driver);
> -	pr_info("Watchdog Module Unloaded\n");
> -}
> -
> -module_init(pcwd_init_module);
> -module_exit(pcwd_cleanup_module);
> +module_isa_driver(pcwd_isa_driver, PCWD_ISA_NR_CARDS);
>  
>  MODULE_AUTHOR("Ken Hollis <kenji@...gate.com>, "
>  		"Wim Van Sebroeck <wim@...ana.be>");
> -- 
> 2.7.3
> 

This patch has been added to linux-watchdog-next.

Kind regards,
Wim.