linux-kernel - Re: [PATCH v2] media: Doc add missing documentation for samsung,exynos4212-jpeg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160717202522.GA8777@rob-hp-laptop>
Date:	Sun, 17 Jul 2016 15:26:04 -0500
From:	Rob Herring <robh@...nel.org>
To:	Shuah Khan <shuahkh@....samsung.com>
Cc:	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	kgene@...nel.org, k.kozlowski@...sung.com, mchehab@....samsung.com,
	andrzej.p@...sung.com, j.anaszewski@...sung.com,
	hans.verkuil@...co.com, javier@....samsung.com,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: Doc add missing documentation for
 samsung,exynos4212-jpeg

On Fri, Jul 15, 2016 at 04:10:27PM -0600, Shuah Khan wrote:
> Add add missing documentation for samsung,exynos4212-jpeg codec,
> reorder entries to improve readability and make it easier to add
> new entries.
> 
> samsung,exynos4212-jpeg and samsung,exynos4210-jpeg are identical,
> hence add samsung,exynos4212-jpeg as deprecated in the documentation.
> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
> 
> Changes since v1:
> - Added samsung,exynos4212-jpeg as deprecated
> 
>  Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> index 38941db..c5399e7 100644
> --- a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> @@ -3,9 +3,11 @@ Samsung S5P/EXYNOS SoC series JPEG codec
>  Required properties:
>  
>  - compatible	: should be one of:
> -		  "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg",
> -		  "samsung,exynos3250-jpeg", "samsung,exynos5420-jpeg",
> +		  "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg",
> +		  "samsung,exynos4210-jpeg", "samsung,exynos5420-jpeg",
>  		  "samsung,exynos5433-jpeg";
> +
> +		  (Deprecated: "samsung,exynos4212-jpeg").

Since you are reformatting, one compatible per line (unless multiple 
apply) is preferred.

>  - reg		: address and length of the JPEG codec IP register set;
>  - interrupts	: specifies the JPEG codec IP interrupt;
>  - clock-names   : should contain:
> -- 
> 2.7.4
>