linux-kernel - Re: [RFC][PATCH 1/7] k3dma: Fix hisi burst clipping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <578C792A.9020404@linaro.org>
Date:	Mon, 18 Jul 2016 14:37:30 +0800
From:	zhangfei <zhangfei.gao@...aro.org>
To:	John Stultz <john.stultz@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>
CC:	Andy Green <andy.green@...aro.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Wei Xu <xuwei5@...ilicon.com>,
	Rob Herring <robh+dt@...nel.org>,
	Andy Green <andy@...mcat.com>,
	Dave Long <dave.long@...aro.org>,
	Guodong Xu <guodong.xu@...aro.org>
Subject: Re: [RFC][PATCH 1/7] k3dma: Fix hisi burst clipping



On 07/16/2016 10:13 AM, John Stultz wrote:
> From: Andy Green <andy.green@...aro.org>
>
> Max burst len is a 4-bit field, but at the moment it's clipped with
> a 5-bit constant... reduce it to that which can be expressed
>
> Cc: Zhangfei Gao <zhangfei.gao@...aro.org>
> Cc: Jingoo Han <jg1.han@...sung.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Cc: Vinod Koul <vinod.koul@...el.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Liam Girdwood <lgirdwood@...il.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: Wei Xu <xuwei5@...ilicon.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Andy Green <andy@...mcat.com>
> Cc: Dave Long <dave.long@...aro.org>
> Cc: Guodong Xu <guodong.xu@...aro.org>
> Signed-off-by: Andy Green <andy.green@...aro.org>
> [jstultz: Forward ported to mainline]
> Signed-off-by: John Stultz <john.stultz@...aro.org>

Acked-by: Zhangfei Gao <zhangfei.gao@...aro.org>

> ---
>   drivers/dma/k3dma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
> index 1ba2fd7..d01a11d 100644
> --- a/drivers/dma/k3dma.c
> +++ b/drivers/dma/k3dma.c
> @@ -552,7 +552,7 @@ static int k3_dma_config(struct dma_chan *chan,
>   	c->ccfg |= (val << 12) | (val << 16);
>
>   	if ((maxburst == 0) || (maxburst > 16))
> -		val = 16;
> +		val = 15;
>   	else
>   		val = maxburst - 1;
>   	c->ccfg |= (val << 20) | (val << 24);
>