linux-kernel - RE: [PATCH v3 2/8] thunderbolt: Updating device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E607265CB020454880711A6F96C05A03893D025E@hasmsx107.ger.corp.intel.com>
Date:	Mon, 18 Jul 2016 09:54:10 +0000
From:	"Levy, Amir (Jer)" <amir.jer.levy@...el.com>
To:	'David Miller' <davem@...emloft.net>,
	'Lukas Wunner' <lukas@...ner.de>
CC:	"andreas.noever@...il.com" <andreas.noever@...il.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	thunderbolt-linux <thunderbolt-linux@...el.com>,
	"Westerberg, Mika" <mika.westerberg@...el.com>,
	"Winkler, Tomas" <tomas.winkler@...el.com>
Subject: RE: [PATCH v3 2/8] thunderbolt: Updating device IDs

On Sat, Jul 16 2016, 12:53 AM, David Miller wrote:
> From: "Levy, Amir (Jer)" <amir.jer.levy@...el.com>
> Date: Fri, 15 Jul 2016 18:56:39 +0000
> 
> > On Fri, Jul 15 2016, 09:49 PM, David Miller wrote:
> >> From: Amir Levy <amir.jer.levy@...el.com>
> >> Date: Thu, 14 Jul 2016 14:28:16 +0300
> >>
> >> > Adding the new Thunderbolt(TM) device IDs to the list.
> >> >
> >> > Signed-off-by: Amir Levy <amir.jer.levy@...el.com>
> >>
> >> Unless these PCI-IDs, all of them, are going to be used in multiple
> >> spots in the kernel, it is not appropriate to add them here.
> >>
> >> They belong as private macros in the drivers themselves, instead.
> >
> > They might be used:
> > http://www.spinics.net/lists/linux-pci/msg51331.html
> 
> Then move them to the common location when this "might" thing actually
> happens.

There are several contradicting  comments about this change (http://www.spinics.net/lists/linux-pci/msg51331.html and http://www.spinics.net/lists/linux-pci/msg51302.html)
I've decided for now to make the new device ids private to the driver. 
This can be changed later when updating quirks for Apple hardware.

Regards,
Amir