linux-kernel - Re: [PATCH] bcache: untagle cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160718102411.t5qm3t6hnjcjpbyr@c203.arch.suse.de>
Date:	Mon, 18 Jul 2016 12:24:11 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Kent Overstreet <kent.overstreet@...il.com>
Cc:	Jens Axboe <axboe@...com>, Eric Wheeler <git@...ux.ewheeler.net>,
	Coly Li <colyli@...e.de>, linux-bcache@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: untagle cache_aolloc

On Mon, Jul 18, 2016 at 02:13:33AM -0800, Kent Overstreet wrote:
> On Mon, Jul 18, 2016 at 12:11:09PM +0200, Johannes Thumshirn wrote:
> > bcache's cache_alloc() function currenty has no way freeing memory if one of
> > the allocations fails. Untangle the if + allocation statement so we have
> > defined checkpoints to free previous allocations if one fails.
> 
> nack. The existing error path handles failure midway through just fine.

Come on, the patch improves the readability of the if statement by some orders
of magnitude as well.

Are you OK with it if I change the subject/commit log?

	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850