lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Jul 2016 16:27:36 +0200 From: Kristian Evensen <kristian.evensen@...il.com> To: Oliver Neukum <oneukum@...e.com> Cc: linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org, Network Development <netdev@...r.kernel.org> Subject: Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum <oneukum@...e.com> wrote: >> Ok, sounds good. So far, I have only seen the random MAC issue with >> the three previously mentioned devices, but who knows how many else is >> out there with the same error ... I don't think it should be in the >> core ethernet code, at least not yet, but I agree it would make sense >> to move it to for example usbnet_core(). If you agree, I can prepare a >> patch for it. > > I don't see how it would be specific for a subsystem. If the patch > is correct, it belongs into the networking core. To me it sounds a bit intrusive to change the networking core for something that has so far only been seen with devices belonging to one subsystem, but I will do it if required. I guess David M. will have an opinion on if we should add this fix on a per-driver basis, in usbnet or in the networking core? If we go for the latter, what would be correct place for this piece of code, register_netdevice()? -Kristian
Powered by blists - more mailing lists