linux-kernel - Re: [PATCH 7/7] dts: hi6220: Add k3-dma and i2s/hdmi audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLVFzHPXpKfkJy657sNFSnVXOh-jERpJwChD=-z6cuL3AQ@mail.gmail.com>
Date:	Mon, 18 Jul 2016 10:20:08 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Wei Xu <xuwei5@...ilicon.com>,
	Rob Herring <robh+dt@...nel.org>,
	Andy Green <andy@...mcat.com>,
	Dave Long <dave.long@...aro.org>,
	Guodong Xu <guodong.xu@...aro.org>
Subject: Re: [PATCH 7/7] dts: hi6220: Add k3-dma and i2s/hdmi audio support

On Sat, Jul 16, 2016 at 4:48 AM, Mark Brown <broonie@...nel.org> wrote:
> On Fri, Jul 15, 2016 at 07:13:27PM -0700, John Stultz wrote:
>
>> Add entry for k3-dma driver and i2s/hdmi audio devices.
>
>> This enables HDMI audio output.
>
> These bindings appear to be undocumented.  All new bindings require
> documentation.

Yea. I figured there would be potentially substantial enough changes
required that doing a initial draft (which given my limited knowledge
of the hardware, would be mostly boilerplate) might not be worth it
for the first RFC.

>> +             i2s0: hi6210_i2s {
>> +                     compatible = "hisilicon,hi6210-i2s";
>> +                     reg = <0x0 0xf7118000 0x0 0x8000>, /* i2s unit */
>> +                           <0x0 0xf7030000 0x0 0x400>,  /* syscon */
>> +                           <0x0 0xf7032000 0x0 0x400>;  /* pmctrl */
>
> Some of this looks like we should be using a system controller binding
> rather than listing the system controller directly here.  The magic
> number indexing for the resources is also not good, we should be using
> reg-names to get name based lookups (I had been going to query that on
> the binding document when I failed to find it...).

Ok. I'll need to dig a bit to understand it better, but will try to
address this.

thanks
-john