linux-kernel - [PATCH] hwmon-ntc_thermistor: Delete an unnecessary check before the function call "iio_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2016 20:54:18 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	linux-hwmon@...r.kernel.org,
	Günter Röck <linux@...ck-us.net>,
	Jean Delvare <jdelvare@...e.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: [PATCH] hwmon-ntc_thermistor: Delete an unnecessary check before the
 function call "iio_channel_release"

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 18 Jul 2016 20:34:41 +0200

The iio_channel_release() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/hwmon/ntc_thermistor.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index 8ef7b71..100878a 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -361,8 +361,7 @@ ntc_thermistor_parse_dt(struct platform_device *pdev)
 }
 static void ntc_iio_channel_release(struct ntc_thermistor_platform_data *pdata)
 {
-	if (pdata->chan)
-		iio_channel_release(pdata->chan);
+	iio_channel_release(pdata->chan);
 }
 #else
 static struct ntc_thermistor_platform_data *
-- 
2.9.2